Skip to content

Closes #5141: Index pandas extension accessor add from_return_msg and other functions #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ajpotts wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Closes #5141: Index pandas extension accessor add from_return_msg and other functions #5205

ajpotts wants to merge 1 commit into from
+490 −7

Conversation

@ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Dec 19, 2025 •
edited
Loading

Overview

This PR improves the pandas-facing Index integration by extending the Index.ak accessor with thin delegations to legacy Arkouda Index / MultiIndex functionality, while keeping the public surface area aligned with pandas semantics.

Changes

  • Add delegation methods on the pandas Index.ak accessor for:
    • concat
    • lookup
    • to_csv, to_parquet, and to_hdf
  • Preserve index name / names during concatenation for both Index and MultiIndex.
  • Clarify and harden MultiIndex.lookup behavior:
    • Explicit validation of key length
    • Clear separation of scalar-key vs array-key semantics
  • Add minimal, focused IO tests that validate round-tripping a pd.Index
    backed by an Arkouda ExtensionArray through:
    • CSV
    • Parquet
    • HDF5

Testing

  • New tests live in tests/pandas/extension/io/index_accessor_io.py
  • Tests intentionally target only the pandas Index + ExtensionArray surface
    and avoid direct use of legacy ak.Index APIs.

Closes #5141: Index pandas extension accessor add from_return_msg and other functions

@ajpotts ajpotts force-pushed the 5141_Index_pandas_extension_accessor_add_from_return_msg branch 4 times, most recently from 5401f1a to b3ec28b Compare December 22, 2025 13:00
@ajpotts ajpotts marked this pull request as ready for review December 22, 2025 19:04
@ajpotts ajpotts marked this pull request as draft December 22, 2025 19:05
@ajpotts ajpotts force-pushed the 5141_Index_pandas_extension_accessor_add_from_return_msg branch from b3ec28b to 7c66362 Compare December 29, 2025 18:12
@ajpotts ajpotts marked this pull request as ready for review December 29, 2025 18:15
@ajpotts ajpotts force-pushed the 5141_Index_pandas_extension_accessor_add_from_return_msg branch from 7c66362 to 0f9b3ec Compare January 13, 2026 19:35
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@714ec23). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main     #5205   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         4           
  Lines           ?        63           
  Branches        ?         0           
========================================
  Hits            ?        63           
  Misses          ?         0           
  Partials        ?         0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1RyanK 1RyanK Awaiting requested review from 1RyanK

@jaketrookman jaketrookman Awaiting requested review from jaketrookman

@drculhane drculhane Awaiting requested review from drculhane

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Implement Pandas ExtensionArray API

Development

Successfully merging this pull request may close these issues.

Index pandas extension accessor add from_return_msg and other functions

2 participants

@ajpotts @codecov-commenter